Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js b/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js |
| index 51bc5562847791c2893962fcfa54ffad9ced9824..b1418dfd97fe521e70556f9aea52e445707edc08 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js |
| @@ -1006,6 +1006,19 @@ WebInspector.CodeMirrorTextEditor.prototype = { |
| }, |
| /** |
| + * @param {number} lineNumber |
| + * @param {number} columnNumber |
| + * @param {?Element} element |
|
lushnikov
2016/07/12 22:38:45
can we make it non-nullable? The less nullable typ
flandy
2016/07/13 18:14:56
Yes, done.
|
| + * @return {!Object} |
|
lushnikov
2016/07/12 22:38:45
let's introduce a type for this. (look at externs.
flandy
2016/07/13 18:14:57
This should be {!CodeMirror.TextMarker}. I've intr
|
| + */ |
| + addBookmark: function(lineNumber, columnNumber, element) |
| + { |
| + return this._codeMirror.setBookmark(new CodeMirror.Pos(lineNumber, columnNumber), { |
| + widget: element |
| + }); |
| + }, |
| + |
| + /** |
| * @override |
| * @return {!Element} |
| */ |