Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2128073002: [css-flexbox] Minor performance optimization (Closed)

Created:
4 years, 5 months ago by cbiesinger
Modified:
4 years, 5 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Minor performance optimization If we lay out the child due to the intrinsic main axis size, we don't have to force-layout it again later. R=dgrogan@chromium.org,eae@chromium.org TEST=n/a, no change in behavior Committed: https://crrev.com/bd50d003d8585043b1f016330ea68f157fae5f41 Cr-Commit-Position: refs/heads/master@{#403976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
cbiesinger
4 years, 5 months ago (2016-07-06 20:48:20 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128073002/1
4 years, 5 months ago (2016-07-06 20:48:48 UTC) #3
eae
Nice! LGTM
4 years, 5 months ago (2016-07-06 20:49:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128073002/1
4 years, 5 months ago (2016-07-06 20:51:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 23:35:02 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:35:04 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 23:36:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd50d003d8585043b1f016330ea68f157fae5f41
Cr-Commit-Position: refs/heads/master@{#403976}

Powered by Google App Engine
This is Rietveld 408576698