Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2128043004: set font cache if null (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

set font cache if null testing/corpus/fx/path/path_10_jd.pdf sets the document to null. (It can't be read at all by MacOS Preview.) This causes the font cache to also be null. In this case, get the font cache from CFX_GEModule instead. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7fb17c0ba0cc551317569baafa44b4785c8f23d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
caryclark
4 years, 5 months ago (2016-07-07 11:41:34 UTC) #1
dsinclair
lgtm
4 years, 5 months ago (2016-07-07 13:37:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128043004/1
4 years, 5 months ago (2016-07-07 13:37:48 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 14:55:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7fb17c0ba0cc551317569baafa44b4785c8f...

Powered by Google App Engine
This is Rietveld 408576698