Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 212803005: Fix for partial filter subregion specification with deferred filters. (Closed)

Created:
6 years, 9 months ago by Stephen White
Modified:
6 years, 9 months ago
Reviewers:
f(malita)
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Fix for partial filter subregion specification with deferred filters. Filter primitive subregions are specified as x/y/width/height, while skia crop rects are left/right/top/bottom. If x is set but width is not, we were only sending the left edge. We must also tell skia the right edge, in order to preserve the rect's original width. Similarly when y is specified but height is not, we must tell skia the new bottom edge. Also changed all this code to use FloatRect instead of SkRect, since these relationships are easier to express. Covered by layout test svg/batik/filters/filterRegions.svg, when run with --enable-deferred-filters. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M Source/platform/graphics/filters/FilterEffect.cpp View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
Florin: PTAL. Thanks!
6 years, 9 months ago (2014-03-26 23:38:40 UTC) #1
f(malita)
lgtm
6 years, 9 months ago (2014-03-27 00:57:36 UTC) #2
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 9 months ago (2014-03-27 01:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/212803005/1
6 years, 9 months ago (2014-03-27 01:00:49 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 01:11:27 UTC) #5
Message was sent while issue was closed.
Change committed as 170116

Powered by Google App Engine
This is Rietveld 408576698