media/filters/ffmpeg_demuxer.cc - Issue 212803004: Separate DemuxerHost from DataSourceHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/ffmpeg_demuxer.cc

Issue 212803004: Separate DemuxerHost from DataSourceHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update other implementations of DataSourceHost and DemuxerHost. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/ffmpeg_demuxer.cc

diff --git a/media/filters/ffmpeg_demuxer.cc b/media/filters/ffmpeg_demuxer.cc

index d2267f32271e0d22a8b72abb82604e9908575427..de1968afc43d200f86f0eeb3791621ce72d54d72 100644

--- a/media/filters/ffmpeg_demuxer.cc

+++ b/media/filters/ffmpeg_demuxer.cc

@@ -444,10 +444,6 @@ void FFmpegDemuxer::Initialize(DemuxerHost* host,

host_ = host;

text_enabled_ = enable_text_tracks;

- // TODO(scherkus): DataSource should have a host by this point,

- // see http://crbug.com/122071

- data_source_->set_host(host);

url_protocol_.reset(new BlockingUrlProtocol(data_source_, BindToCurrentLoop(

base::Bind(&FFmpegDemuxer::OnDataSourceError, base::Unretained(this)))));

glue_.reset(new FFmpegGlue(url_protocol_.get()));