Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2128013003: Update markdown to use absolute image paths, fixing broken images (Closed)

Created:
4 years, 5 months ago by pdr.
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update markdown to use absolute image paths, fixing broken images Markdown can be served with or without a trailing slash but when a trailing slash is present, relative image links were broken. The following example works as expected: url: https://skia.org/dev/design/pdftheory image url: PdfLogicalDocumentStructure.png resolves to: https://skia.org/dev/design/PdfLogicalDocumentStructure.png The following example was broken before this patch: url: https://skia.org/dev/design/pdftheory/ image url: PdfLogicalDocumentStructure.png resolves to: https://skia.org/dev/design/pdftheory/PdfLogicalDocumentStructure.png The PdfLogicalDocumentStructure.png file lives in /dev/design/, not /dev/design/pdftheory/. This patch updates all images in our markdown files to be served with the full path so a trailing slash no longer breaks images. I hit this bug when promoting the new Skia debugger: https://groups.google.com/a/chromium.org/d/msg/paint-dev/QJ8xpu8dNyA/F4KX2O4ZBwAJ BUG=skia:5493 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128013003 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2128013003 Committed: https://skia.googlesource.com/skia/+/c42475cea23bfdb22b5d6cad6042577e47bd6a5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M site/dev/design/pdftheory.md View 1 chunk +1 line, -1 line 0 comments Download
M site/dev/tools/debugger.md View 1 chunk +1 line, -1 line 0 comments Download
M site/dev/tools/markdown.md View 1 chunk +1 line, -1 line 0 comments Download
M site/dev/tools/qtdebugger.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
pdr.
4 years, 5 months ago (2016-07-07 17:39:58 UTC) #3
mtklein
lgtm Nice find!
4 years, 5 months ago (2016-07-07 21:47:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128013003/1
4 years, 5 months ago (2016-07-07 21:47:57 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 21:48:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c42475cea23bfdb22b5d6cad6042577e47bd6a5c

Powered by Google App Engine
This is Rietveld 408576698