src/platform/crash/crash_reporter.cc - Issue 2128004: Adding in-process crash dumping library and crash uploader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform/crash/crash_reporter.cc

Issue 2128004: Adding in-process crash dumping library and crash uploader (Closed) Base URL: ssh://git@chromiumos-git//chromeos

Patch Set: respond to review and add another test Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/platform/crash/crash_reporter.cc

diff --git a/src/platform/crash/crash_reporter.cc b/src/platform/crash/crash_reporter.cc

index 15b9687061cb632fa3543eb3f2f9b8b8e0f9ac41..3112fd384a6569d0988c2a20007ae49f5320315e 100644

--- a/src/platform/crash/crash_reporter.cc

+++ b/src/platform/crash/crash_reporter.cc

@@ -12,12 +12,14 @@

#include "gflags/gflags.h"

#include "metrics/metrics_library.h"

+#pragma GCC diagnostic ignored "-Wstrict-aliasing"

DEFINE_bool(init, false, "Initialize crash logging");

DEFINE_bool(clean_shutdown, false, "Signal clean shutdown");

DEFINE_string(exec, "", "Executable name crashed");

DEFINE_int32(pid, -1, "Crashing PID");

DEFINE_int32(signal, -1, "Signal causing crash");

DEFINE_bool(unclean_check, true, "Check for unclean shutdown");

+#pragma GCC diagnostic error "-Wstrict-aliasing"

static const char kCrashCounterHistogram[] = "Logging.CrashCounter";

static const char kUncleanShutdownFile[] =

« no previous file with comments | « src/platform/crash/crash_dumper.cc ('k') | src/platform/crash/crash_sender » ('j') | no next file with comments »