Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 212793013: Change UnsafePersistent<.> to Eternal<.> in V8PerIsolateData. (Closed)

Created:
6 years, 9 months ago by vogelheim
Modified:
6 years, 8 months ago
Reviewers:
dcarney
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Change UnsafePersistent<.> to Eternal<.> in V8PerIsolateData. This is split out from 206533004, as it's largely unrelated to the remaining changes there. BUG=276323 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/bindings/v8/V8PerIsolateData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8PerIsolateData.cpp View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vogelheim
6 years, 9 months ago (2014-03-27 15:27:53 UTC) #1
dcarney
lgtm
6 years, 9 months ago (2014-03-27 16:33:06 UTC) #2
vogelheim
The CQ bit was checked by vogelheim@chromium.org
6 years, 9 months ago (2014-03-27 17:21:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vogelheim@chromium.org/212793013/1
6 years, 9 months ago (2014-03-27 17:21:20 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 19:06:48 UTC) #5
Message was sent while issue was closed.
Change committed as 170196

Powered by Google App Engine
This is Rietveld 408576698