Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 212793011: Removed 'executable' bits from header. (Closed)

Created:
6 years, 9 months ago by Sven Panne
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Removed 'executable' bits from header. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A include/v8-debug.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
The text diff is actually not *that* helpful... ;-)
6 years, 9 months ago (2014-03-27 12:11:46 UTC) #1
Jakob Kummerow
LGTM. I'm surprised that git-cl even let you upload this :-)
6 years, 9 months ago (2014-03-27 12:13:39 UTC) #2
Sven Panne
6 years, 9 months ago (2014-03-27 12:15:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20298 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698