Issue 212793004: Adds RenderFrameObserver::DidFinishDocumentLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212793004: Adds RenderFrameObserver::DidFinishDocumentLoad (Closed)

Created:
6 years, 9 months ago by sky

Modified:
6 years, 9 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Adds RenderFrameObserver::DidFinishDocumentLoad No doubt we can remove RenderViewObserver::DidFinishDocumentLoad(), but that can be done separately (there is already a TODO for it). BUG=none TEST=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260119

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	content/public/renderer/render_frame_observer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/renderer/render_frame_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/212793004/1

6 years, 9 months ago (2014-03-27 21:35:36 UTC) #4

sky

6 years, 9 months ago (2014-03-28 13:53:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r260119 (presubmit successful).