Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212793003: Volume adjust sound is played only if spoken feedback is enabled. (Closed)

Created:
6 years, 9 months ago by ygorshenin1
Modified:
6 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Volume adjust sound is played only if spoken feedback is enabled. BUG=356366 TEST=browser_tests:VolumeControllerSoundsTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc View 3 chunks +23 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
ygorshenin1
6 years, 9 months ago (2014-03-26 12:48:33 UTC) #1
ygorshenin1
Oshima, could you please take a look at this CL? We're in hurry to land ...
6 years, 9 months ago (2014-03-27 09:53:41 UTC) #2
oshima
lgtm
6 years, 9 months ago (2014-03-27 18:41:16 UTC) #3
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 9 months ago (2014-03-27 18:51:24 UTC) #4
ygorshenin1
Many thanks!
6 years, 9 months ago (2014-03-27 18:51:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/212793003/1
6 years, 9 months ago (2014-03-27 18:52:08 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 00:58:18 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 00:58:19 UTC) #8
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 9 months ago (2014-03-28 04:49:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/212793003/1
6 years, 9 months ago (2014-03-28 04:50:04 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 04:52:05 UTC) #11
Message was sent while issue was closed. 
Change committed as 260073

Powered by Google App Engine
This is Rietveld 408576698