Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: LayoutTests/webaudio/dom-exceptions.html

Issue 212793002: Fix attributes types on AnalyserNode as specification of web audio. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add basic layoutTest and domexception test for equal values between min and max value. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/webaudio/dom-exceptions.html
diff --git a/LayoutTests/webaudio/dom-exceptions.html b/LayoutTests/webaudio/dom-exceptions.html
index d18575f6123821fb7769a86a1f1832e1a0782b65..fdaa4a18f24ba3b4cd1484bfac4b8889a9ed024e 100644
--- a/LayoutTests/webaudio/dom-exceptions.html
+++ b/LayoutTests/webaudio/dom-exceptions.html
@@ -73,6 +73,8 @@ function runTest() {
shouldThrow("node.minDecibels = -10");
shouldThrow("node.maxDecibels = -150");
+ shouldThrow("node.minDecibels = -30");
+ shouldThrow("node.maxDecibels = -100");
Raymond Toy 2014/03/27 17:33:09 How are these two tests different from the two abo
KhNo 2014/03/28 02:25:23 -30 and -100 are default values. There were bugs w
Raymond Toy 2014/03/28 16:10:06 Ah, so we set minDecibels = -30, which is the same
shouldThrow("node.smoothingTimeConstant = -0.1");
shouldThrow("node.smoothingTimeConstant = 1.5");
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | LayoutTests/webaudio/realtimeanalyser-basic.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698