LayoutTests/webaudio/dom-exceptions.html - Issue 212793002: Fix attributes types on AnalyserNode as specification of web audio.

Side by Side Diff: LayoutTests/webaudio/dom-exceptions.html

Issue 212793002: Fix attributes types on AnalyserNode as specification of web audio. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add basic layoutTest and domexception test for equal values between min and max value. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">	1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="resources/audio-testing.js"></script>	4 <script src="resources/audio-testing.js"></script>

5 <script src="../resources/js-test.js"></script>	5 <script src="../resources/js-test.js"></script>

6 <script src="resources/biquad-testing.js"></script>	6 <script src="resources/biquad-testing.js"></script>

7 </head>	7 </head>

8	8

9 <body>	9 <body>

10	10

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66	66

67 // Analysers	67 // Analysers

68 node = context.createAnalyser();	68 node = context.createAnalyser();

69 // Invalid fftSize: IndexSizeError	69 // Invalid fftSize: IndexSizeError

70 shouldThrow("node.fftSize = 42");	70 shouldThrow("node.fftSize = 42");

71 shouldThrow("node.fftSize = 16");	71 shouldThrow("node.fftSize = 16");

72 shouldThrow("node.fftSize = 4096");	72 shouldThrow("node.fftSize = 4096");

73	73

74 shouldThrow("node.minDecibels = -10");	74 shouldThrow("node.minDecibels = -10");

75 shouldThrow("node.maxDecibels = -150");	75 shouldThrow("node.maxDecibels = -150");

	76 shouldThrow("node.minDecibels = -30");

	77 shouldThrow("node.maxDecibels = -100");
	Raymond Toy 2014/03/27 17:33:09 How are these two tests different from the two abo How are these two tests different from the two above? KhNo 2014/03/28 02:25:23 -30 and -100 are default values. There were bugs w Show quoted text On 2014/03/27 17:33:09, Raymond Toy wrote: > How are these two tests different from the two above? -30 and -100 are default values. There were bugs when those are set exactly same value. Previously There are just existed about bigger or less values. Raymond Toy 2014/03/28 16:10:06 Ah, so we set minDecibels = -30, which is the same Show quoted text On 2014/03/28 02:25:23, KhNo wrote: > On 2014/03/27 17:33:09, Raymond Toy wrote: > > How are these two tests different from the two above? > > -30 and -100 are default values. > There were bugs when those are set exactly same value. > Previously There are just existed about bigger or less values. Ah, so we set minDecibels = -30, which is the same as maxDecibels, so we should signal an error, as required. Nice catch.
76 shouldThrow("node.smoothingTimeConstant = -0.1");	78 shouldThrow("node.smoothingTimeConstant = -0.1");

77 shouldThrow("node.smoothingTimeConstant = 1.5");	79 shouldThrow("node.smoothingTimeConstant = 1.5");

78	80

79 // AudioBuffers	81 // AudioBuffers

80 node = context.createBuffer(1,1, context.sampleRate);	82 node = context.createBuffer(1,1, context.sampleRate);

81 // Invalid channel index: IndexSizeError	83 // Invalid channel index: IndexSizeError

82 shouldThrow("node.getChannelData(2)");	84 shouldThrow("node.getChannelData(2)");

83	85

84 // AudioNode connections	86 // AudioNode connections

85 node = context.createGain();	87 node = context.createGain();

(...skipping 87 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
173 shouldNotThrow("conv = oc.createConvolver()");	175 shouldNotThrow("conv = oc.createConvolver()");

174 shouldThrow("conv.buffer = oc.createBuffer(1, 100, 22050)");	176 shouldThrow("conv.buffer = oc.createBuffer(1, 100, 22050)");

175 }	177 }

176	178

177 runTest();	179 runTest();

178 successfullyParsed = true;	180 successfullyParsed = true;

179	181

180 </script>	182 </script>

181 </body>	183 </body>

182 </html>	184 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | LayoutTests/webaudio/realtimeanalyser-basic.html » ('J')