Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2127923003: [Layout API] Use API shim in LayoutObjectTest (Closed)

Created:
4 years, 5 months ago by pilgrim_google
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use API shim in LayoutObjectTest As this test resides in core/layout/ and is directly testing the layout object itself, there's no particular reason to rewrite it to route everything through the block layout API. The only reason it would come up is that it relies on Document::layoutView(), which is being replaced in other code with Document::layoutViewItem(). Instead, I'm going to poke through the API and allow this privileged code to access the underlying layout object. There are no functional changes. BUG=499321 Committed: https://crrev.com/fc379556cd1f1cafb51f1ddb86bf34255e9c526f Cr-Commit-Position: refs/heads/master@{#403934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 5 months ago (2016-07-06 17:14:33 UTC) #2
eae
LGTM
4 years, 5 months ago (2016-07-06 17:23:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127923003/1
4 years, 5 months ago (2016-07-06 17:23:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 18:27:07 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 18:31:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc379556cd1f1cafb51f1ddb86bf34255e9c526f
Cr-Commit-Position: refs/heads/master@{#403934}

Powered by Google App Engine
This is Rietveld 408576698