Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2127883004: Refresh Public Suffic List to the latest version (Closed)

Created:
4 years, 5 months ago by Ryan Sleevi
Modified:
4 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffic List to the latest version This updates from revision 2226f9cc92213d0d68a74ecb535b15b3af00388a (2016-05-09) to revision 28e17a0f8f26f1bddfbd62d9861b223efa7792bc (2016-07-06) R=pkasting@chromium.org BUG=610498 Committed: https://crrev.com/7eb9569bab0c7fd0fad826a5b691892f393a2141 Cr-Commit-Position: refs/heads/master@{#404050}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -25 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.dat View 20 chunks +207 lines, -17 lines 2 comments Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 75 chunks +126 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Ryan Sleevi
4 years, 5 months ago (2016-07-06 23:51:07 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/2127883004/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/2127883004/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode10660 net/base/registry_controlled_domains/effective_tld_names.dat:10660: compute-1.amazonaws.com The ordering in here isn't alphabetical by ...
4 years, 5 months ago (2016-07-07 00:35:36 UTC) #2
Ryan Sleevi
On 2016/07/07 00:35:36, Peter Kasting wrote: > LGTM > > https://codereview.chromium.org/2127883004/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat > File net/base/registry_controlled_domains/effective_tld_names.dat (right): ...
4 years, 5 months ago (2016-07-07 00:50:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127883004/1
4 years, 5 months ago (2016-07-07 00:52:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 02:50:47 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 02:50:50 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 02:52:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7eb9569bab0c7fd0fad826a5b691892f393a2141
Cr-Commit-Position: refs/heads/master@{#404050}

Powered by Google App Engine
This is Rietveld 408576698