Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2127883003: Move chooser_controller directory from //components to //chrome/browser (Closed)

Created:
4 years, 5 months ago by juncai
Modified:
4 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, extensions-reviews_chromium.org, msramek+watch_chromium.org, droger+watchlist_chromium.org, tfarina, sdefresne+watchlist_chromium.org, raymes+watch_chromium.org, blundell+watchlist_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move chooser_controller directory from //components to //chrome/browser Since chooser_controller is only called by //chrome, this CL moved the directory from //components to //chrome/browser. The context is: https://bugs.chromium.org/p/chromium/issues/detail?id=624590 BUG=611917 Committed: https://crrev.com/badc1daaca94e5ac2d4c1ed07f0f70f0e8360a05 Cr-Commit-Position: refs/heads/master@{#404725}

Patch Set 1 : moved chooser_controller directory from //components to //chrome/browser #

Patch Set 2 : moved mock_chooser_controller.* to test_support_common #

Patch Set 3 : moved mock_chooser_controller.* to test_support_common #

Patch Set 4 : moved mock_chooser_controller.* to test_support_common #

Patch Set 5 : moved mock_chooser_controller.* to test_support_common #

Patch Set 6 : rebase #

Patch Set 7 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -295 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
A + chrome/browser/chooser_controller/OWNERS View 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chooser_controller/README View 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chooser_controller/chooser_controller.h View 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chooser_controller/chooser_controller.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chooser_controller/mock_chooser_controller.h View 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chooser_controller/mock_chooser_controller.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/DEPS View 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/bluetooth/bluetooth_chooser_controller.h View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_dialogs_views.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chooser_content_view.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chooser_content_view_unittest.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/chooser_dialog_view.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc View 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/chooser_bubble_delegate.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_chooser_controller.h View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 3 chunks +4 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M components/OWNERS View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
D components/chooser_controller.gypi View 2 3 4 1 chunk +0 lines, -43 lines 0 comments Download
D components/chooser_controller/BUILD.gn View 2 3 4 1 chunk +0 lines, -34 lines 0 comments Download
D components/chooser_controller/DEPS View 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
D components/chooser_controller/OWNERS View 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
D components/chooser_controller/README View 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
D components/chooser_controller/chooser_controller.h View 2 3 4 1 chunk +0 lines, -92 lines 0 comments Download
D components/chooser_controller/chooser_controller.cc View 2 3 4 1 chunk +0 lines, -18 lines 0 comments Download
D components/chooser_controller/mock_chooser_controller.h View 2 3 4 1 chunk +0 lines, -36 lines 0 comments Download
D components/chooser_controller/mock_chooser_controller.cc View 2 3 4 1 chunk +0 lines, -36 lines 0 comments Download
M components/components.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 25 (15 generated)
juncai
Please take a look.
4 years, 5 months ago (2016-07-06 23:42:35 UTC) #7
jam
lgtm
4 years, 5 months ago (2016-07-09 02:20:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127883003/80001
4 years, 5 months ago (2016-07-10 23:05:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/33274) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-10 23:07:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127883003/120001
4 years, 5 months ago (2016-07-11 17:34:22 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253121)
4 years, 5 months ago (2016-07-11 19:49:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127883003/120001
4 years, 5 months ago (2016-07-11 19:51:30 UTC) #20
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-11 20:37:12 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 20:37:28 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 20:39:14 UTC) #25
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/badc1daaca94e5ac2d4c1ed07f0f70f0e8360a05
Cr-Commit-Position: refs/heads/master@{#404725}

Powered by Google App Engine
This is Rietveld 408576698