Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2127863003: fix for gcc 4.4 build (Closed)

Created:
4 years, 5 months ago by fbarchard1
Modified:
4 years, 5 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Avoid gcc 4.4 indexing a vector_size(32) array error. Mking color conversion use simple arrays within structure, which will be referenced via register pointer. R=harryjin@google.com BUG=libyuv:616 TEST=CC=gcc-4.4 CXX=g++-4.4 LD=ld-4.4 make -f linux.mk Committed: https://chromium.googlesource.com/libyuv/libyuv/+/303b9f03c826296fcacf4678d8a2ed708a918044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 1 chunk +7 lines, -7 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M linux.mk View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
fbarchard1
4 years, 5 months ago (2016-07-06 22:03:02 UTC) #1
harryjin
lgtm
4 years, 5 months ago (2016-07-06 22:05:17 UTC) #2
fbarchard1
4 years, 5 months ago (2016-07-06 22:14:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
303b9f03c826296fcacf4678d8a2ed708a918044 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698