Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2127853002: Disable Quick View by default and add about flag to enable it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chromeos/chromeos_switches.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1952 matching lines...) Expand 10 before | Expand all | Expand 10 after
1963 FEATURE_VALUE_TYPE(password_manager::features::kFillOnAccountSelect)}, 1963 FEATURE_VALUE_TYPE(password_manager::features::kFillOnAccountSelect)},
1964 {"new-audio-rendering-mixing-strategy", // FLAGS:RECORD_UMA 1964 {"new-audio-rendering-mixing-strategy", // FLAGS:RECORD_UMA
1965 IDS_NEW_AUDIO_RENDERING_MIXING_STRATEGY_NAME, 1965 IDS_NEW_AUDIO_RENDERING_MIXING_STRATEGY_NAME,
1966 IDS_NEW_AUDIO_RENDERING_MIXING_STRATEGY_DESCRIPTION, 1966 IDS_NEW_AUDIO_RENDERING_MIXING_STRATEGY_DESCRIPTION,
1967 kOsWin | kOsMac | kOsLinux | kOsAndroid, 1967 kOsWin | kOsMac | kOsLinux | kOsAndroid,
1968 FEATURE_VALUE_TYPE(media::kNewAudioRenderingMixingStrategy)}, 1968 FEATURE_VALUE_TYPE(media::kNewAudioRenderingMixingStrategy)},
1969 #if defined(OS_CHROMEOS) 1969 #if defined(OS_CHROMEOS)
1970 {"enable-intent-picker", IDS_ENABLE_INTENT_PICKER, 1970 {"enable-intent-picker", IDS_ENABLE_INTENT_PICKER,
1971 IDS_ENABLE_INTENT_PICKER_DESCRIPTION, kOsCrOS, 1971 IDS_ENABLE_INTENT_PICKER_DESCRIPTION, kOsCrOS,
1972 SINGLE_VALUE_TYPE(switches::kEnableIntentPicker)}, 1972 SINGLE_VALUE_TYPE(switches::kEnableIntentPicker)},
1973 {"files-quick-view", IDS_FLAGS_FILES_QUICK_VIEW_NAME,
1974 IDS_FLAGS_FILES_QUICK_VIEW_DESCRIPTION, kOsCrOS,
1975 ENABLE_DISABLE_VALUE_TYPE(chromeos::switches::kEnableFilesQuickView,
1976 chromeos::switches::kDisableFilesQuickView)},
1973 #endif // defined(OS_CHROMEOS) 1977 #endif // defined(OS_CHROMEOS)
1974 // NOTE: Adding new command-line switches requires adding corresponding 1978 // NOTE: Adding new command-line switches requires adding corresponding
1975 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 1979 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
1976 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 1980 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
1977 }; 1981 };
1978 1982
1979 class FlagsStateSingleton { 1983 class FlagsStateSingleton {
1980 public: 1984 public:
1981 FlagsStateSingleton() 1985 FlagsStateSingleton()
1982 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 1986 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
2161 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2165 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2162 2166
2163 const FeatureEntry* GetFeatureEntries(size_t* count) { 2167 const FeatureEntry* GetFeatureEntries(size_t* count) {
2164 *count = arraysize(kFeatureEntries); 2168 *count = arraysize(kFeatureEntries);
2165 return kFeatureEntries; 2169 return kFeatureEntries;
2166 } 2170 }
2167 2171
2168 } // namespace testing 2172 } // namespace testing
2169 2173
2170 } // namespace about_flags 2174 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chromeos/chromeos_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698