Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 212783002: make sure fields are initialized in OverflowEventDispatcher (Closed)

Created:
6 years, 9 months ago by Mostyn Bramley-Moore
Modified:
6 years, 8 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

make sure fields are initialized in OverflowEventDispatcher This makes sure some older compilers don't complain that these member variables might be used uninitialized. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/rendering/RenderBlock.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mostyn Bramley-Moore
@Julien: PTAL at this trivial patch...
6 years, 8 months ago (2014-04-07 16:00:40 UTC) #1
Julien - ping for review
lgtm
6 years, 8 months ago (2014-04-08 22:32:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/212783002/1
6 years, 8 months ago (2014-04-08 22:33:05 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 23:41:45 UTC) #4
Message was sent while issue was closed.
Change committed as 171094

Powered by Google App Engine
This is Rietveld 408576698