Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2127813002: Revert of Add crash instrumentation for crbug.com/621147 (Closed)

Created:
4 years, 5 months ago by Jakob Kummerow
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add crash instrumentation for crbug.com/621147 (patchset #1 id:1 of https://codereview.chromium.org/2114743002/ ) Reason for revert: Bug found and fixed: crrev.com/7614362b7e619f9c6c1d2681c6de02b966782d0e Instrumentation no longer needed. Original issue's description: > Add crash instrumentation for crbug.com/621147 > > BUG=chromium:621147 > LOG=N > R=ishell@chromium.org,cbruni@chromium.org > > Committed: https://crrev.com/5ff508a82299f20a0d9828cf73072a4f4772fab8 > Cr-Commit-Position: refs/heads/master@{#37328} TBR=verwaest@chromium.org,cbruni@chromium.org,ishell@chromium.org,mlippautz@chromium.org,adamk@chromium.org BUG=chromium:621147, chromium:624764 Committed: https://crrev.com/a182588d49ee9084ed4dcee799e59cea3473fa32 Cr-Commit-Position: refs/heads/master@{#37552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M src/ic/ic.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jakob Kummerow
Created Revert of Add crash instrumentation for crbug.com/621147
4 years, 5 months ago (2016-07-06 12:34:19 UTC) #1
Jakob Kummerow
4 years, 5 months ago (2016-07-06 12:34:37 UTC) #2
Michael Lippautz
lgtm
4 years, 5 months ago (2016-07-06 12:58:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127813002/1
4 years, 5 months ago (2016-07-06 13:03:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 13:28:48 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 13:31:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a182588d49ee9084ed4dcee799e59cea3473fa32
Cr-Commit-Position: refs/heads/master@{#37552}

Powered by Google App Engine
This is Rietveld 408576698