Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2127793002: Retain coordinator and update label in UpdatePasswordInfoBarController (Closed)

Created:
4 years, 5 months ago by Jackie Quinn
Modified:
4 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retain coordinator and update label in UpdatePasswordInfoBarController Fixes for UpdatePasswordInfoBarController. SelectorCoordinator is retained as a property so that it is not immediately dismissed, and the infobar label is updated in the SelectorCoordinatorDelegate callback. BUG=622244 Committed: https://crrev.com/cf96aefe1fe6512a6422a88e94d47dcc23e462a9 Cr-Commit-Position: refs/heads/master@{#403892}

Patch Set 1 #

Patch Set 2 : Retain coordinator and update label in UpdatePasswordInfoBarController #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M ios/chrome/browser/passwords/update_password_infobar_controller.mm View 1 4 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jackie Quinn
4 years, 5 months ago (2016-07-06 12:08:12 UTC) #2
vabr (Chromium)
lgtm
4 years, 5 months ago (2016-07-06 12:20:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127793002/20001
4 years, 5 months ago (2016-07-06 12:34:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 13:17:56 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 13:20:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf96aefe1fe6512a6422a88e94d47dcc23e462a9
Cr-Commit-Position: refs/heads/master@{#403892}

Powered by Google App Engine
This is Rietveld 408576698