chrome/browser/ui/search/search_tab_helper.cc - Issue 2127783002: Make EmitNtpStatistics() private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 2127783002: Make EmitNtpStatistics() private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/search_tab_helper.cc

diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc

index acb2a86f90dd76e92359b0848145160ce4c2ada6..2ba04505a85de5bc8d11a6e6b0628dafb7a04f54 100644

--- a/chrome/browser/ui/search/search_tab_helper.cc

+++ b/chrome/browser/ui/search/search_tab_helper.cc

@@ -387,7 +387,7 @@ void SearchTabHelper::MostVisitedItemsChanged(

const std::vector<InstantMostVisitedItem>& items) {

// When most visited change, the NTP usually reloads the tiles. This means

// our metrics get inconsistent. So we'd rather emit stats now.

- InstantTab::EmitNtpStatistics(web_contents_);

+ InstantTab::MostVisitedItemsChanged(web_contents_);

ipc_router_.SendMostVisitedItems(items);

LogMostVisitedItemsSource(items);

}