Make EmitNtpStatistics() private.

Make EmitNtpStatistics() private.

It's still called from the same places, but through public functions
that describe what is happening and why, rather than exposing an
implementation detail.

Also, add an enum so that it's immediately obvious at the call site why
EmitNtpStatistics() is being called.

BUG=625990
Committed: https://crrev.com/c48795c69de4878814ca44038544c1afd78c1dce
Cr-Commit-Position: refs/heads/master@{#404636}

[sfiera, 2016-07-06 11:51:20]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2016-07-06 12:04:28]

lgtm

https://codereview.chromium.org/2127783002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc (right):

https://codereview.chromium.org/2127783002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc:255: void
NTPUserDataLogger::EmitNtpStatistics(EmitReason reason) {
We don't do anything with the reason yet - do you have any plans there?

https://codereview.chromium.org/2127783002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/ntp_user_data_logger.h (right):

https://codereview.chromium.org/2127783002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/ntp_user_data_logger.h:68: // INTNERNAL_FLUSH).
nit: typo

[sfiera, 2016-07-06 12:08:41]

https://codereview.chromium.org/2127783002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc (right):

https://codereview.chromium.org/2127783002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc:255: void
NTPUserDataLogger::EmitNtpStatistics(EmitReason reason) {
On 2016/07/06 12:04:27, Marc Treib wrote:
> We don't do anything with the reason yet - do you have any plans there?

Not at the moment. It would be nice to have a statistic to the effect of "how
did the user leave the NTP?" but this isn't good enough to be used for that
purpose yet.

https://codereview.chromium.org/2127783002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/ntp_user_data_logger.h (right):

https://codereview.chromium.org/2127783002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/ntp_user_data_logger.h:68: // INTNERNAL_FLUSH).
On 2016/07/06 12:04:27, Marc Treib wrote:
> nit: typo

Done.

[sfiera, 2016-07-06 12:08:45]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-07-06 12:08:46]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2127783002/#ps20001
(title: "Make EmitNtpStatistics() private.")

[commit-bot: I haz the power, 2016-07-06 12:08:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 12:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 12:16:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sfiera, 2016-07-06 14:07:06]

Description was changed from

==========
Make EmitNtpStatistics() private.

It's still called from the same places, but through public functions
that describe what is happening and why, rather than exposing an
implementation detail.

Also, add an enum so that it's immediately obvious at the call site why
EmitNtpStatistics() is being called.

BUG=611341
==========

to

==========
Make EmitNtpStatistics() private.

It's still called from the same places, but through public functions
that describe what is happening and why, rather than exposing an
implementation detail.

Also, add an enum so that it's immediately obvious at the call site why
EmitNtpStatistics() is being called.

BUG=625990
==========

[sfiera, 2016-07-11 10:33:06]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 10:33:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 10:45:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 10:45:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sfiera, 2016-07-11 11:35:23]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-07-11 11:35:24]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2127783002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-07-11 11:35:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 12:17:18]

Description was changed from

==========
Make EmitNtpStatistics() private.

It's still called from the same places, but through public functions
that describe what is happening and why, rather than exposing an
implementation detail.

Also, add an enum so that it's immediately obvious at the call site why
EmitNtpStatistics() is being called.

BUG=625990
==========

to

==========
Make EmitNtpStatistics() private.

It's still called from the same places, but through public functions
that describe what is happening and why, rather than exposing an
implementation detail.

Also, add an enum so that it's immediately obvious at the call site why
EmitNtpStatistics() is being called.

BUG=625990
==========

[commit-bot: I haz the power, 2016-07-11 12:17:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-11 12:19:26]

Description was changed from

==========
Make EmitNtpStatistics() private.

It's still called from the same places, but through public functions
that describe what is happening and why, rather than exposing an
implementation detail.

Also, add an enum so that it's immediately obvious at the call site why
EmitNtpStatistics() is being called.

BUG=625990
==========

to

==========
Make EmitNtpStatistics() private.

It's still called from the same places, but through public functions
that describe what is happening and why, rather than exposing an
implementation detail.

Also, add an enum so that it's immediately obvious at the call site why
EmitNtpStatistics() is being called.

BUG=625990

Committed: https://crrev.com/c48795c69de4878814ca44038544c1afd78c1dce
Cr-Commit-Position: refs/heads/master@{#404636}
==========

[commit-bot: I haz the power, 2016-07-11 12:19:27]

Patchset 5 (id:??) landed as
https://crrev.com/c48795c69de4878814ca44038544c1afd78c1dce
Cr-Commit-Position: refs/heads/master@{#404636}