Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2127733002: Fix in preparation of fat builds. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix in preparation of fat builds. The "ios_bundle_data" target will need to create more intermediate targets that will have to be in the visibility list, so use ":*" as the visibility to restrict it to target defined in the same file. BUG=603180 Committed: https://crrev.com/0a9838464e81581ae9b560f9556ee50abe5176cc Cr-Commit-Position: refs/heads/master@{#403912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M testing/test.gni View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sdefresne
Please take a look.
4 years, 5 months ago (2016-07-06 09:51:54 UTC) #2
sdefresne
+Paweł for OWNERS
4 years, 5 months ago (2016-07-06 09:52:55 UTC) #4
Olivier
lgtm
4 years, 5 months ago (2016-07-06 11:16:44 UTC) #5
Paweł Hajdan Jr.
LGTM
4 years, 5 months ago (2016-07-06 15:22:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127733002/1
4 years, 5 months ago (2016-07-06 16:10:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 16:15:59 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 16:18:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a9838464e81581ae9b560f9556ee50abe5176cc
Cr-Commit-Position: refs/heads/master@{#403912}

Powered by Google App Engine
This is Rietveld 408576698