Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: Source/devtools/front_end/HeapSnapshotProxy.js

Issue 212773005: DevTools: Show all objects in class view in advanced heap snapshot mode. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/HeapSnapshotProxy.js
diff --git a/Source/devtools/front_end/HeapSnapshotProxy.js b/Source/devtools/front_end/HeapSnapshotProxy.js
index 660ddde1a985511014e4d5f2b2926ad79ee236a2..3798991bc1a014f6777638e53d764193eaeb413e 100644
--- a/Source/devtools/front_end/HeapSnapshotProxy.js
+++ b/Source/devtools/front_end/HeapSnapshotProxy.js
@@ -223,7 +223,7 @@ WebInspector.HeapSnapshotProxyObject.prototype = {
* @param {string} methodName
* @param {function (new:T, ...[?])} proxyConstructor
* @param {...*} var_args
- * @return {?WebInspector.HeapSnapshotProviderProxy}
+ * @return {?T}
* @template T
*/
callFactoryMethod: function(callback, methodName, proxyConstructor, var_args)
@@ -296,7 +296,8 @@ WebInspector.HeapSnapshotLoaderProxy.prototype = {
{
if (callback)
callback();
- this.callFactoryMethod(updateStaticData.bind(this), "buildSnapshot", WebInspector.HeapSnapshotProxy);
+ var showHiddenData = WebInspector.settings.showAdvancedHeapSnapshotProperties.get();
+ this.callFactoryMethod(updateStaticData.bind(this), "buildSnapshot", WebInspector.HeapSnapshotProxy, showHiddenData);
}
/**
@@ -362,22 +363,20 @@ WebInspector.HeapSnapshotProxy.prototype = {
/**
* @param {number} nodeIndex
- * @param {boolean} showHiddenData
* @return {?WebInspector.HeapSnapshotProviderProxy}
*/
- createEdgesProvider: function(nodeIndex, showHiddenData)
+ createEdgesProvider: function(nodeIndex)
{
- return this.callFactoryMethod(null, "createEdgesProvider", WebInspector.HeapSnapshotProviderProxy, nodeIndex, showHiddenData);
+ return this.callFactoryMethod(null, "createEdgesProvider", WebInspector.HeapSnapshotProviderProxy, nodeIndex);
},
/**
* @param {number} nodeIndex
- * @param {boolean} showHiddenData
* @return {?WebInspector.HeapSnapshotProviderProxy}
*/
- createRetainingEdgesProvider: function(nodeIndex, showHiddenData)
+ createRetainingEdgesProvider: function(nodeIndex)
{
- return this.callFactoryMethod(null, "createRetainingEdgesProvider", WebInspector.HeapSnapshotProviderProxy, nodeIndex, showHiddenData);
+ return this.callFactoryMethod(null, "createRetainingEdgesProvider", WebInspector.HeapSnapshotProviderProxy, nodeIndex);
},
/**

Powered by Google App Engine
This is Rietveld 408576698