Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1505)

Unified Diff: Source/devtools/front_end/HeapSnapshot.js

Issue 212773005: DevTools: Show all objects in class view in advanced heap snapshot mode. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/HeapSnapshot.js
diff --git a/Source/devtools/front_end/HeapSnapshot.js b/Source/devtools/front_end/HeapSnapshot.js
index 736d02a36082b383d66dfc7138ab73e20afdccc0..c72d3f0b88150a7080153924736cd7779c873af2 100644
--- a/Source/devtools/front_end/HeapSnapshot.js
+++ b/Source/devtools/front_end/HeapSnapshot.js
@@ -863,9 +863,10 @@ WebInspector.HeapSnapshotProgress.prototype = {
/**
* @param {!WebInspector.HeapSnapshotProgress} progress
+ * @param {boolean} showHiddenData
* @constructor
*/
-WebInspector.HeapSnapshot = function(profile, progress)
+WebInspector.HeapSnapshot = function(profile, progress, showHiddenData)
{
this._nodes = profile.nodes;
this._containmentEdges = profile.edges;
@@ -883,6 +884,7 @@ WebInspector.HeapSnapshot = function(profile, progress)
this._aggregatesForDiff = null;
this._aggregates = {};
this._aggregatesSortedFlags = {};
+ this._showHiddenData = showHiddenData;
this._init();
@@ -1920,23 +1922,14 @@ WebInspector.HeapSnapshot.prototype = {
return result;
},
- _parseFilter: function(filter)
- {
- if (!filter)
- return null;
- var parsedFilter = eval("(function(){return " + filter + "})()");
- return parsedFilter.bind(this);
- },
-
/**
* @param {number} nodeIndex
- * @param {boolean} showHiddenData
* @return {!WebInspector.HeapSnapshotEdgesProvider}
*/
- createEdgesProvider: function(nodeIndex, showHiddenData)
+ createEdgesProvider: function(nodeIndex)
{
var node = this.createNode(nodeIndex);
- var filter = this.containmentEdgesFilter(showHiddenData);
+ var filter = this.containmentEdgesFilter();
var indexProvider = new WebInspector.HeapSnapshotEdgeIndexProvider(this);
return new WebInspector.HeapSnapshotEdgesProvider(this, filter, node.edges(), indexProvider);
},
@@ -1953,32 +1946,29 @@ WebInspector.HeapSnapshot.prototype = {
},
/**
- * @param {boolean} showHiddenData
* @return {?function(!WebInspector.HeapSnapshotEdge):boolean}
*/
- retainingEdgesFilter: function(showHiddenData)
+ retainingEdgesFilter: function()
{
return null;
},
/**
- * @param {boolean} showHiddenData
* @return {?function(!WebInspector.HeapSnapshotEdge):boolean}
*/
- containmentEdgesFilter: function(showHiddenData)
+ containmentEdgesFilter: function()
{
return null;
},
/**
* @param {number} nodeIndex
- * @param {boolean} showHiddenData
* @return {!WebInspector.HeapSnapshotEdgesProvider}
*/
- createRetainingEdgesProvider: function(nodeIndex, showHiddenData)
+ createRetainingEdgesProvider: function(nodeIndex)
{
var node = this.createNode(nodeIndex);
- var filter = this.retainingEdgesFilter(showHiddenData);
+ var filter = this.retainingEdgesFilter();
var indexProvider = new WebInspector.HeapSnapshotRetainerEdgeIndexProvider(this);
return new WebInspector.HeapSnapshotEdgesProvider(this, filter, node.retainers(), indexProvider);
},

Powered by Google App Engine
This is Rietveld 408576698