DevTools: Show all objects in class view in advanced heap snapshot mode.

DevTools: Show all objects in class view in advanced heap snapshot mode.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170170

[alph, 2014-03-26 17:22:21]

ptal

[yurys, 2014-03-27 07:35:41]

lgtm

https://codereview.chromium.org/212773005/diff/1/LayoutTests/inspector/profil...
File LayoutTests/inspector/profiler/heap-snapshot.html (right):

https://codereview.chromium.org/212773005/diff/1/LayoutTests/inspector/profil...
LayoutTests/inspector/profiler/heap-snapshot.html:358: var result =
loader.buildSnapshot();
buildSnapshot(false)

https://codereview.chromium.org/212773005/diff/1/Source/devtools/front_end/He...
File Source/devtools/front_end/HeapSnapshotView.js (left):

https://codereview.chromium.org/212773005/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshotView.js:876: perspective.activate(this);
Why did this move?

[alph, 2014-03-27 09:39:31]

https://codereview.chromium.org/212773005/diff/1/LayoutTests/inspector/profil...
File LayoutTests/inspector/profiler/heap-snapshot.html (right):

https://codereview.chromium.org/212773005/diff/1/LayoutTests/inspector/profil...
LayoutTests/inspector/profiler/heap-snapshot.html:358: var result =
loader.buildSnapshot();
On 2014/03/27 07:35:41, yurys wrote:
> buildSnapshot(false)

Done.

https://codereview.chromium.org/212773005/diff/1/Source/devtools/front_end/He...
File Source/devtools/front_end/HeapSnapshotView.js (left):

https://codereview.chromium.org/212773005/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshotView.js:876: perspective.activate(this);
On 2014/03/27 07:35:41, yurys wrote:
> Why did this move?

activate calls show on grids, which in turn send ContentShown event handled in
dataGridContentShown.
This function won't invoke the callback if dataGrid is not [yet] switched.

[alph, 2014-03-27 09:39:43]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2014-03-27 09:39:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alph@chromium.org/212773005/20001

[commit-bot: I haz the power, 2014-03-27 09:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 09:39:58]

Failed to apply patch for Source/devtools/front_end/HeapSnapshotGridNodes.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/HeapSnapshotGridNodes.js
  Hunk #1 FAILED at 684.
  Hunk #2 succeeded at 841 (offset 38 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/devtools/front_end/HeapSnapshotGridNodes.js.rej

Patch:       Source/devtools/front_end/HeapSnapshotGridNodes.js
Index: Source/devtools/front_end/HeapSnapshotGridNodes.js
diff --git a/Source/devtools/front_end/HeapSnapshotGridNodes.js
b/Source/devtools/front_end/HeapSnapshotGridNodes.js
index
f1e5592ac653dd26248472554393f904fff738d7..af018a08b42e432d8edc54f2bc3b9d32a312e04e
100644
--- a/Source/devtools/front_end/HeapSnapshotGridNodes.js
+++ b/Source/devtools/front_end/HeapSnapshotGridNodes.js
@@ -684,12 +684,11 @@ WebInspector.HeapSnapshotObjectNode.prototype = {
     createProvider: function()
     {
         var tree = this._dataGrid;
-        var showHiddenData =
WebInspector.settings.showAdvancedHeapSnapshotProperties.get();
         var snapshot = this._isFromBaseSnapshot ? tree.baseSnapshot :
tree.snapshot;
         if (this.showRetainingEdges)
-            return
snapshot.createRetainingEdgesProvider(this.snapshotNodeIndex, showHiddenData);
+            return
snapshot.createRetainingEdgesProvider(this.snapshotNodeIndex);
         else
-            return snapshot.createEdgesProvider(this.snapshotNodeIndex,
showHiddenData);
+            return snapshot.createEdgesProvider(this.snapshotNodeIndex);
     },
 
     _findAncestorWithSameSnapshotNodeId: function()
@@ -803,10 +802,7 @@ WebInspector.HeapSnapshotInstanceNode.prototype = {
      */
     createProvider: function()
     {
-        var showHiddenData =
WebInspector.settings.showAdvancedHeapSnapshotProperties.get();
-        return this._baseSnapshotOrSnapshot.createEdgesProvider(
-            this.snapshotNodeIndex,
-            showHiddenData);
+        return
this._baseSnapshotOrSnapshot.createEdgesProvider(this.snapshotNodeIndex);
     },
 
     _createChildNode: function(item)

[alph, 2014-03-27 10:21:01]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2014-03-27 10:21:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alph@chromium.org/212773005/30008

[commit-bot: I haz the power, 2014-03-27 10:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 10:30:54]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[alph, 2014-03-27 11:27:52]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2014-03-27 11:28:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alph@chromium.org/212773005/30008

[commit-bot: I haz the power, 2014-03-27 12:10:39]

Change committed as 170170