Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: test/mjsunit/array-constructor-feedback.js

Issue 2127713003: [TurboFan] Improve Array constructor optimization (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Test file fixes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | test/mjsunit/array-feedback.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax --expose-gc 28 // Flags: --allow-natives-syntax --expose-gc
29 // Flags: --noalways-opt
29 30
30 // Test element kind of objects. 31 // Test element kind of objects.
31 32
32 var elements_kind = { 33 var elements_kind = {
33 fast_smi_only : 'fast smi only elements', 34 fast_smi_only : 'fast smi only elements',
34 fast : 'fast elements', 35 fast : 'fast elements',
35 fast_double : 'fast double elements', 36 fast_double : 'fast double elements',
36 dictionary : 'dictionary elements', 37 dictionary : 'dictionary elements',
37 external_byte : 'external byte elements', 38 external_byte : 'external byte elements',
38 external_unsigned_byte : 'external unsigned byte elements', 39 external_unsigned_byte : 'external unsigned byte elements',
(...skipping 15 matching lines...) Expand all
54 55
55 function isHoley(obj) { 56 function isHoley(obj) {
56 if (%HasFastHoleyElements(obj)) return true; 57 if (%HasFastHoleyElements(obj)) return true;
57 return false; 58 return false;
58 } 59 }
59 60
60 function assertKind(expected, obj, name_opt) { 61 function assertKind(expected, obj, name_opt) {
61 assertEquals(expected, getKind(obj), name_opt); 62 assertEquals(expected, getKind(obj), name_opt);
62 } 63 }
63 64
64 // Test: If a call site goes megamorphic, it retains the ability to
65 // use allocation site feedback (if FLAG_allocation_site_pretenuring
66 // is on).
67 (function() {
68 function bar(t, len) {
69 return new t(len);
70 }
71
72 a = bar(Array, 10);
73 a[0] = 3.5;
74 b = bar(Array, 1);
75 assertKind(elements_kind.fast_double, b);
76 c = bar(Object, 3);
77 b = bar(Array, 10);
78 // TODO(mvstanton): re-enable when FLAG_allocation_site_pretenuring
79 // is on in the build.
80 // assertKind(elements_kind.fast_double, b);
81 })();
82
83
84 // Test: ensure that crankshafted array constructor sites are deopted 65 // Test: ensure that crankshafted array constructor sites are deopted
85 // if another function is used. 66 // if another function is used.
86 (function() { 67 (function() {
87 function bar0(t) { 68 function bar0(t) {
88 return new t(); 69 return new t();
89 } 70 }
90 a = bar0(Array); 71 a = bar0(Array);
91 a[0] = 3.5; 72 a[0] = 3.5;
92 b = bar0(Array); 73 b = bar0(Array);
93 assertKind(elements_kind.fast_double, b); 74 assertKind(elements_kind.fast_double, b);
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 bar(size)[0] = 'string'; 208 bar(size)[0] = 'string';
228 var res = bar(size); 209 var res = bar(size);
229 assertKind(elements_kind.fast, bar(size)); 210 assertKind(elements_kind.fast, bar(size));
230 %OptimizeFunctionOnNextCall(bar); 211 %OptimizeFunctionOnNextCall(bar);
231 assertKind(elements_kind.fast, bar(size)); 212 assertKind(elements_kind.fast, bar(size));
232 // But there is a limit, based on the size of the old generation, currently 213 // But there is a limit, based on the size of the old generation, currently
233 // 22937600, but double it to prevent the test being too brittle. 214 // 22937600, but double it to prevent the test being too brittle.
234 var large_size = 22937600 * 2; 215 var large_size = 22937600 * 2;
235 assertKind(elements_kind.dictionary, bar(large_size)); 216 assertKind(elements_kind.dictionary, bar(large_size));
236 })(); 217 })();
OLDNEW
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | test/mjsunit/array-feedback.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698