Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2127713003: [TurboFan] Improve Array constructor optimization (Closed)

Created:
4 years, 5 months ago by mvstanton
Modified:
4 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TurboFan] Improve Array constructor optimization And in so doing, enable a handful of excluded tests. BUG= Committed: https://crrev.com/a80164ec43ad1092a4f649979333eeec506594ec Cr-Commit-Position: refs/heads/master@{#37559}

Patch Set 1 #

Patch Set 2 : nit. #

Patch Set 3 : release compile fix. #

Total comments: 2

Patch Set 4 : Test file fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -92 lines) Patch
M src/compiler/js-create-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 2 3 2 chunks +136 lines, -4 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +7 lines, -61 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 2 chunks +1 line, -20 lines 0 comments Download
M test/mjsunit/array-feedback.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mvstanton
Hi Michael, Here is the CL we discussed, thanks for the look! --Mike
4 years, 5 months ago (2016-07-06 14:17:35 UTC) #2
Michael Starzinger
LGTM. Cool. https://codereview.chromium.org/2127713003/diff/40001/src/compiler/js-create-lowering.cc File src/compiler/js-create-lowering.cc (right): https://codereview.chromium.org/2127713003/diff/40001/src/compiler/js-create-lowering.cc#newcode627 src/compiler/js-create-lowering.cc:627: nit: We could DCHECK(arity > 1) here.
4 years, 5 months ago (2016-07-06 14:34:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127713003/60001
4 years, 5 months ago (2016-07-06 14:48:38 UTC) #6
mvstanton
Thanks! Updated the test file as well for the ignition failures. https://codereview.chromium.org/2127713003/diff/40001/src/compiler/js-create-lowering.cc File src/compiler/js-create-lowering.cc (right): ...
4 years, 5 months ago (2016-07-06 14:48:46 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-06 15:16:05 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 15:17:21 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a80164ec43ad1092a4f649979333eeec506594ec
Cr-Commit-Position: refs/heads/master@{#37559}

Powered by Google App Engine
This is Rietveld 408576698