Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2127703004: [ios] Removed WebUI ios provider headers as unused. (Closed)

Created:
4 years, 5 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 5 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed WebUI ios provider headers as unused. BUG=524467 Committed: https://crrev.com/2eaf5026683bacf68be54dbacd4dab91dee4f4a2 Cr-Commit-Position: refs/heads/master@{#403966}

Patch Set 1 #

Patch Set 2 : Actually removed headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M ios/provider/ios_provider_web.gyp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ios/public/provider/web/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
D ios/public/provider/web/web_ui_ios.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D ios/public/provider/web/web_ui_ios_controller.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D ios/public/provider/web/web_ui_ios_controller_factory.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D ios/public/provider/web/web_ui_ios_message_handler.h View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127703004/1
4 years, 5 months ago (2016-07-06 15:25:46 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/31494) ios-device-gn on ...
4 years, 5 months ago (2016-07-06 15:27:18 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127703004/20001
4 years, 5 months ago (2016-07-06 15:33:42 UTC) #6
Eugene But (OOO till 7-30)
4 years, 5 months ago (2016-07-06 16:45:53 UTC) #8
sdefresne
lgtm
4 years, 5 months ago (2016-07-06 16:47:44 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99017)
4 years, 5 months ago (2016-07-06 16:57:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127703004/20001
4 years, 5 months ago (2016-07-06 17:14:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99102)
4 years, 5 months ago (2016-07-06 20:12:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127703004/20001
4 years, 5 months ago (2016-07-06 20:47:20 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 23:12:10 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:12:30 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 23:14:05 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2eaf5026683bacf68be54dbacd4dab91dee4f4a2
Cr-Commit-Position: refs/heads/master@{#403966}

Powered by Google App Engine
This is Rietveld 408576698