src/gpu/batches/GrAAConvexPathRenderer.cpp - Issue 2127673002: Consolidate handling of infinitely thin primitives and aa bloat handing WRT batch bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/batches/GrAAConvexPathRenderer.cpp

Issue 2127673002: Consolidate handling of infinitely thin primitives and aa bloat handing WRT batch bounds (Closed) Base URL: https://skia.googlesource.com/skia.git@AAStrokeRect

Patch Set: comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/gpu/GrOvalRenderer.cpp ('K') | « src/gpu/GrOvalRenderer.cpp ('k') | src/gpu/batches/GrAADistanceFieldPathRenderer.cpp » ('j') | src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/gpu/batches/GrAAConvexPathRenderer.cpp

diff --git a/src/gpu/batches/GrAAConvexPathRenderer.cpp b/src/gpu/batches/GrAAConvexPathRenderer.cpp

index 2c5b4fef5f364b5d14fee9709e5b33b006a50ab5..91ee71a4897ed8e1b0649a420fda60695069b374 100644

--- a/src/gpu/batches/GrAAConvexPathRenderer.cpp

+++ b/src/gpu/batches/GrAAConvexPathRenderer.cpp

@@ -746,9 +746,8 @@ public:

AAConvexPathBatch(GrColor color, const SkMatrix& viewMatrix, const SkPath& path)

: INHERITED(ClassID()) {

fGeoData.emplace_back(Geometry{color, viewMatrix, path});

robertphillips 2016/07/07 20:26:42 Why no AABloat ?

bsalomon 2016/07/07 23:40:57 Done.

- // compute bounds

- fBounds = path.getBounds();

- viewMatrix.mapRect(&fBounds);

+ this->setTransformedBounds(path.getBounds(), viewMatrix, HasAABloat::kNo,

+ IsZeroArea::kNo);

}

const char* name() const override { return "AAConvexBatch"; }

@@ -958,7 +957,7 @@ private:

}

fGeoData.push_back_n(that->fGeoData.count(), that->fGeoData.begin());

- this->joinBounds(that->bounds());

+ this->joinBounds(*that);

return true;

}

« src/gpu/GrOvalRenderer.cpp ('K') | « src/gpu/GrOvalRenderer.cpp ('k') | src/gpu/batches/GrAADistanceFieldPathRenderer.cpp » ('j') | src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp » ('J')