Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9377)

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 2127653002: Add policy to control valid UDP port range in WebRTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tnagel's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc
index a765274cdbeda2a058d22944007848c473962b1c..74a0479a9b1399ed267add69da21ba0ad7f4babd 100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -118,6 +118,7 @@
#include "components/strings/grit/components_strings.h"
#include "components/translate/core/browser/language_state.h"
#include "components/translate/core/browser/translate_infobar_delegate.h"
+#include "components/user_prefs/user_prefs.h"
#include "components/variations/service/variations_service.h"
#include "components/version_info/version_info.h"
#include "content/public/browser/browser_child_process_host_iterator.h"
@@ -279,6 +280,11 @@ const base::FilePath::CharType kUnpackedFullscreenAppName[] =
FILE_PATH_LITERAL("fullscreen_app");
#endif // !defined(OS_MACOSX)
+#if defined(ENABLE_WEBRTC)
+// Arbitrary port range for testing the WebRTC UDP port policy.
+const char kTestWebRtcUdpPortRange[] = "10000-10100";
+#endif
+
// Filters requests to the hosts in |urls| and redirects them to the test data
// dir through URLRequestMockHTTPJobs.
void RedirectHostsToTestData(const char* const urls[], size_t size) {
@@ -3741,6 +3747,54 @@ IN_PROC_BROWSER_TEST_F(MediaRouterDisabledPolicyTest, MediaRouterDisabled) {
}
#endif // defined(ENABLE_MEDIA_ROUTER)
+#if defined(ENABLE_WEBRTC)
+// Sets the proper policy before the browser is started.
+template <bool enable>
+class WebRtcUdpPortRangePolicyTest : public PolicyTest {
+ public:
+ WebRtcUdpPortRangePolicyTest() = default;
+ void SetUpInProcessBrowserTestFixture() override {
+ PolicyTest::SetUpInProcessBrowserTestFixture();
+ PolicyMap policies;
+ if (enable) {
+ policies.Set(
+ key::kWebRtcUdpPortRange, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+ POLICY_SOURCE_CLOUD,
+ base::WrapUnique(new base::StringValue(kTestWebRtcUdpPortRange)),
+ nullptr);
+ }
+ provider_.UpdateChromePolicy(policies);
+ }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(WebRtcUdpPortRangePolicyTest<enable>);
+};
+
+using WebRtcUdpPortRangeEnabledPolicyTest = WebRtcUdpPortRangePolicyTest<true>;
+using WebRtcUdpPortRangeDisabledPolicyTest =
+ WebRtcUdpPortRangePolicyTest<false>;
+
+IN_PROC_BROWSER_TEST_F(WebRtcUdpPortRangeEnabledPolicyTest,
+ WebRtcUdpPortRangeEnabled) {
+ std::string port_range;
+ const PrefService::Preference* pref =
+ user_prefs::UserPrefs::Get(browser()->profile())
+ ->FindPreference(prefs::kWebRTCUDPPortRange);
+ pref->GetValue()->GetAsString(&port_range);
+ EXPECT_EQ(kTestWebRtcUdpPortRange, port_range);
+}
+
+IN_PROC_BROWSER_TEST_F(WebRtcUdpPortRangeDisabledPolicyTest,
+ WebRtcUdpPortRangeDisabled) {
+ std::string port_range;
+ const PrefService::Preference* pref =
+ user_prefs::UserPrefs::Get(browser()->profile())
+ ->FindPreference(prefs::kWebRTCUDPPortRange);
+ pref->GetValue()->GetAsString(&port_range);
+ EXPECT_TRUE(port_range.empty());
+}
+#endif // defined(ENABLE_WEBRTC)
+
#if !defined(OS_CHROMEOS)
// Similar to PolicyTest but sets the proper policy before the browser is
// started.
« no previous file with comments | « chrome/browser/policy/configuration_policy_handler_list_factory.cc ('k') | chrome/browser/renderer_preferences_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698