Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2127643002: Reland "[heap] Track length for array buffers to avoid free-ing dependency" (Closed)

Created:
4 years, 5 months ago by Michael Lippautz
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Track length for array buffers to avoid free-ing dependency" The dependency would only happen if we have a smi overflow for the length and have create a heap number. In this case the heap number would've to survive until the array buffer is collected. To avoid this dependency we track the length (as we previously used to). BUG=chromium:625752 LOG=N TEST=test/mjsunit/regress/regress-625752.js R=hpayer@chromium.org This reverts commit 1791d7bb9ad26d8096bc5e2ed2216ea8b8dcc3cd. Committed: https://crrev.com/da3745d8d9a40e6abd6449e9bdeb38df19b2c6fe Cr-Commit-Position: refs/heads/master@{#37537}

Patch Set 1 #

Patch Set 2 : Skip on GC stress #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -17 lines) Patch
M src/heap/array-buffer-tracker.h View 4 chunks +5 lines, -4 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/heap/array-buffer-tracker-inl.h View 2 chunks +8 lines, -6 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-625752.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Michael Lippautz
4 years, 5 months ago (2016-07-05 15:43:05 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127643002/20001
4 years, 5 months ago (2016-07-05 15:43:19 UTC) #5
Hannes Payer (out of office)
lgtm
4 years, 5 months ago (2016-07-05 15:52:19 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-05 16:06:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127643002/20001
4 years, 5 months ago (2016-07-05 16:29:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-05 16:31:45 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/da3745d8d9a40e6abd6449e9bdeb38df19b2c6fe Cr-Commit-Position: refs/heads/master@{#37537}
4 years, 5 months ago (2016-07-05 16:32:25 UTC) #14
Michael Achenbach
Not sure if relevant. We're seeing this flaky OOM now: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/11455/steps/Check%20-%20isolates%20%28flakes%29/logs/regress-625752
4 years, 5 months ago (2016-07-06 12:06:28 UTC) #15
Michael Lippautz
4 years, 5 months ago (2016-07-06 12:13:49 UTC) #16
Message was sent while issue was closed.
On 2016/07/06 12:06:28, Michael Achenbach wrote:
> Not sure if relevant. We're seeing this flaky OOM now:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/11455/steps...

Thanks, we'll remove the test in https://codereview.chromium.org/2127803002

It was useful to reproduce locally but it creates too much heap pressure (OOM,
slowness) to be useful on the bots.

Powered by Google App Engine
This is Rietveld 408576698