Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 212763008: Clean up runtime functions for Maths. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -145 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/harmony-math.js View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +1 line, -21 lines 0 comments Download
M src/math.js View 3 chunks +6 lines, -6 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/runtime.h View 5 chunks +21 lines, -17 lines 0 comments Download
M src/runtime.cc View 1 8 chunks +15 lines, -15 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 9 months ago (2014-03-27 12:48:44 UTC) #1
Dmitry Lomov
lgtm with a nit https://codereview.chromium.org/212763008/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/212763008/diff/1/src/runtime.cc#newcode7777 src/runtime.cc:7777: RUNTIME_FUNCTION(MaybeObject*, Runtime_MathLog) { Isn't this ...
6 years, 9 months ago (2014-03-27 14:11:03 UTC) #2
Yang
https://codereview.chromium.org/212763008/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/212763008/diff/1/src/runtime.cc#newcode7777 src/runtime.cc:7777: RUNTIME_FUNCTION(MaybeObject*, Runtime_MathLog) { On 2014/03/27 14:11:03, Dmitry Lomov wrote: ...
6 years, 9 months ago (2014-03-27 14:45:28 UTC) #3
Yang
6 years, 9 months ago (2014-03-27 14:46:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20307 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698