Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212763004: Use SYZYASAN instead of ADDRESS_SANITIZER. (Closed)

Created:
6 years, 9 months ago by Sébastien Marchand
Modified:
6 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, plundblad+watch_chromium.org, tzik, aboxhall+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, dmikurube+memory_chromium.org, dtseng+watch_chromium.org, caitkp+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, erikwright+watch_chromium.org, dmazzoni+watch_chromium.org, hans, Timur Iskhodzhanov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use SYZYASAN instead of ADDRESS_SANITIZER. Committed manually by chrisha@: https://codereview.chromium.org/212643015/ We've seen different failure related to the fact that we use the same flag without providing the same API and functionality. BUG=

Patch Set 1 : #

Total comments: 10

Patch Set 2 : Address Nico's nits. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M base/allocator/allocator_shim.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M base/process/process_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/security_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_timeouts.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/tools_sanity_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M build/common.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/accessibility/accessibility_extension_apitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/active_tab_apitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/context_menus/context_menu_apitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_apitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/chrome_version_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_interactive_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/elf_imports_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Sébastien Marchand
Hey Chris, can you take a look at this before I try to find a ...
6 years, 9 months ago (2014-03-26 18:47:50 UTC) #1
chrisha
lgtm
6 years, 9 months ago (2014-03-26 18:55:57 UTC) #2
Sébastien Marchand
+darin@, thakis@ and robertshield@ for owner approval.
6 years, 9 months ago (2014-03-26 20:29:17 UTC) #3
robertshield
chrome_elf: LGTM
6 years, 9 months ago (2014-03-26 20:32:40 UTC) #4
Nico
lgtm! https://codereview.chromium.org/212763004/diff/20001/chrome/browser/accessibility/accessibility_extension_apitest.cc File chrome/browser/accessibility/accessibility_extension_apitest.cc (right): https://codereview.chromium.org/212763004/diff/20001/chrome/browser/accessibility/accessibility_extension_apitest.cc#newcode15 chrome/browser/accessibility/accessibility_extension_apitest.cc:15: // Times out on win asan, http://crbug.com/166026 change ...
6 years, 9 months ago (2014-03-26 20:34:53 UTC) #5
Sébastien Marchand
Thanks, it seems that thakis@ have a lot of power and is owner of all ...
6 years, 9 months ago (2014-03-26 20:47:33 UTC) #6
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 9 months ago (2014-03-26 20:47:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/212763004/40001
6 years, 9 months ago (2014-03-26 20:48:44 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 20:49:09 UTC) #9
commit-bot: I haz the power
Failed to apply patch for build/common.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-26 20:49:09 UTC) #10
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 9 months ago (2014-03-26 21:33:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/212763004/60001
6 years, 9 months ago (2014-03-26 21:35:55 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 22:16:22 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57663
6 years, 9 months ago (2014-03-26 22:16:22 UTC) #14
Sébastien Marchand
+jamesr@chromium.org for owner approval for content/renderer/render_frame_impl.cc
6 years, 9 months ago (2014-03-26 22:41:32 UTC) #15
Sébastien Marchand
6 years, 9 months ago (2014-03-26 22:41:58 UTC) #16
Sébastien Marchand
jamesr@ is ooo and is the only owner for content/renderer/render_frame_impl.cc , Chris, do you mind ...
6 years, 9 months ago (2014-03-26 22:43:56 UTC) #17
Sébastien Marchand
6 years, 9 months ago (2014-03-27 15:17:48 UTC) #18
Message was sent while issue was closed. 
Committed manually by chrisha@: https://codereview.chromium.org/212643015/

Powered by Google App Engine
This is Rietveld 408576698