Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 2127553004: Roll DEPS for v8 to 820a23aa. (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Roll DEPS for v8 to 820a23aa. Also roll DEPS for ICU to ffa4b670 and add a needed GYP variable. BUG= R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7e6a8484b05819268b4e7f0350cebfb704c6d18c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M build_gyp/standalone.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/jsapi/fxjs_v8.cpp View 2 chunks +14 lines, -3 lines 0 comments Download
M fxjse/context.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M fxjse/runtime.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-06 09:11:44 UTC) #1
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-06 17:51:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127553004/1
4 years, 5 months ago (2016-07-06 17:51:14 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 18:02:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7e6a8484b05819268b4e7f0350cebfb704c6...

Powered by Google App Engine
This is Rietveld 408576698