Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2127553003: Speculative nullptr dereference fix for HarfBuzz face creation (Closed)

Created:
4 years, 5 months ago by drott
Modified:
4 years, 5 months ago
Reviewers:
kojii, eae, behdad
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative nullptr dereference fix for HarfBuzz face creation BUG=624088 Committed: https://crrev.com/2204caeff04f85a6445606ab962f8d06145addd8 Cr-Commit-Position: refs/heads/master@{#403873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127553003/1
4 years, 5 months ago (2016-07-05 14:27:15 UTC) #2
drott
4 years, 5 months ago (2016-07-05 14:27:29 UTC) #4
kojii
lgtm
4 years, 5 months ago (2016-07-05 15:06:11 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/250251)
4 years, 5 months ago (2016-07-05 15:58:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127553003/1
4 years, 5 months ago (2016-07-06 08:07:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 09:13:42 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 09:13:48 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2204caeff04f85a6445606ab962f8d06145addd8 Cr-Commit-Position: refs/heads/master@{#403873}
4 years, 5 months ago (2016-07-06 09:15:57 UTC) #13
eae
4 years, 5 months ago (2016-07-06 16:09:54 UTC) #14
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698