Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2127553002: Revert of Generate localizable strings in binary1 property list format. (Closed)

Created:
4 years, 5 months ago by jif
Modified:
4 years, 5 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@{0}
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Generate localizable strings in binary1 property list format. (patchset #2 id:20001 of https://codereview.chromium.org/2121773002/ ) Reason for revert: This breaks the iOS gyp build (gn build works fine). https://crbug.com/625819 Original issue's description: > Generate localizable strings in binary1 property list format. > > Instead of converting the generated files from the old legacy format > to binary1 property list format when creating the application bundle, > directly generate them in the correct format. > > BUG=625578 > > Committed: https://crrev.com/2e4013a84448cf8e714034e3d9d49d11cdf03227 > Cr-Commit-Position: refs/heads/master@{#403679} TBR=stkhapugin@chromium.org,sdefresne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=625578 Committed: https://crrev.com/46e4613bc67b1fea0fc34893a51b88ad6b276ab3 Cr-Commit-Position: refs/heads/master@{#403770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M ios/chrome/tools/strings/generate_localizable_strings.mm View 6 chunks +35 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jif
Created Revert of Generate localizable strings in binary1 property list format.
4 years, 5 months ago (2016-07-05 12:08:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127553002/1
4 years, 5 months ago (2016-07-05 12:08:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 12:09:15 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/46e4613bc67b1fea0fc34893a51b88ad6b276ab3 Cr-Commit-Position: refs/heads/master@{#403770}
4 years, 5 months ago (2016-07-05 12:10:31 UTC) #7
sdefresne
4 years, 5 months ago (2016-07-07 07:54:44 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2130693002/ by sdefresne@chromium.org.

The reason for reverting is: gyp was fixed with
https://codereview.chromium.org/2117353002/ and the roll landed with
https://codereview.chromium.org/2123963002/.

Relanding..

Powered by Google App Engine
This is Rietveld 408576698