Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1991)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 2127533003: Remove PasswordForm::ssl_valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust //ios Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
index f3ecee1e8032b2c72f37cab1429f5d24ddfd2a2d..b7ea954d6af09f7b6aa911f5bf12aea0d47a4e24 100644
--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
@@ -374,7 +374,7 @@ class NativeBackendLibsecretTest : public testing::Test {
const PasswordForm& form,
const std::string& app_string) {
EXPECT_EQ(UTF16ToUTF8(form.password_value), item->value->password);
- EXPECT_EQ(22u, g_hash_table_size(item->attributes));
+ EXPECT_EQ(21u, g_hash_table_size(item->attributes));
CheckStringAttribute(item, "origin_url", form.origin.spec());
CheckStringAttribute(item, "action_url", form.action.spec());
CheckStringAttribute(item, "username_element",
@@ -386,7 +386,6 @@ class NativeBackendLibsecretTest : public testing::Test {
CheckStringAttribute(item, "submit_element",
UTF16ToUTF8(form.submit_element));
CheckStringAttribute(item, "signon_realm", form.signon_realm);
- CheckUint32Attribute(item, "ssl_valid", form.ssl_valid);
CheckUint32Attribute(item, "preferred", form.preferred);
// We don't check the date created. It varies.
CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user);
@@ -934,14 +933,14 @@ TEST_F(NativeBackendLibsecretTest, SomeKeyringAttributesAreMissing) {
// Remove a string attribute.
(*global_mock_libsecret_items)[0]->RemoveAttribute("avatar_url");
// Remove an integer attribute.
- (*global_mock_libsecret_items)[0]->RemoveAttribute("ssl_valid");
+ (*global_mock_libsecret_items)[0]->RemoveAttribute("times_used");
ScopedVector<autofill::PasswordForm> form_list;
EXPECT_TRUE(backend.GetAutofillableLogins(&form_list));
EXPECT_EQ(1u, form_list.size());
EXPECT_EQ(GURL(""), form_list[0]->icon_url);
- EXPECT_FALSE(form_list[0]->ssl_valid);
+ EXPECT_EQ(0, form_list[0]->times_used);
}
TEST_F(NativeBackendLibsecretTest, ReadDuplicateForms) {
« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret.cc ('k') | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698