Chromium Code Reviews| Index: include/v8.h |
| diff --git a/include/v8.h b/include/v8.h |
| index 83da77b3d145f2b3532c366306d5ff063da17805..d05906a8359fe5ae21dcae5383e5012c57b8c72d 100644 |
| --- a/include/v8.h |
| +++ b/include/v8.h |
| @@ -4417,17 +4417,17 @@ typedef bool (*AccessCheckCallback)(Local<Context> accessing_context, |
| * The following example shows how to use a FunctionTemplate: |
| * |
| * \code |
| - * v8::Local<v8::FunctionTemplate> t = v8::FunctionTemplate::New(); |
| - * t->Set("func_property", v8::Number::New(1)); |
| + * v8::Local<v8::FunctionTemplate> t = v8::FunctionTemplate::New(isolate); |
| + * t->Set(isolate, "func_property", v8::Number::New(isolate, 1)); |
| * |
| * v8::Local<v8::Template> proto_t = t->PrototypeTemplate(); |
| - * proto_t->Set("proto_method", v8::FunctionTemplate::New(InvokeCallback)); |
| - * proto_t->Set("proto_const", v8::Number::New(2)); |
| + * proto_t->Set(isolate, "proto_method", v8::FunctionTemplate::New(isolate, InvokeCallback)); |
|
danno
2016/07/06 09:17:46
You will need to reformat by hand, since this line
|
| + * proto_t->Set(isolate, "proto_const", v8::Number::New(isolate, 2)); |
| * |
| * v8::Local<v8::ObjectTemplate> instance_t = t->InstanceTemplate(); |
| - * instance_t->SetAccessor("instance_accessor", InstanceAccessorCallback); |
| - * instance_t->SetNamedPropertyHandler(PropertyHandlerCallback, ...); |
| - * instance_t->Set("instance_property", Number::New(3)); |
| + * instance_t->SetAccessor(String::NewFromUtf8(isolate, "instance_accessor"), InstanceAccessorCallback); |
| + * instance_t->SetNamedPropertyHandler(PropertyHandlerCallback); |
| + * instance_t->Set(String::NewFromUtf8(isolate, "instance_property"), Number::New(isolate, 3)); |
| * |
| * v8::Local<v8::Function> function = t->GetFunction(); |
| * v8::Local<v8::Object> instance = function->NewInstance(); |