Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2127523003: Updating the code example in FunctionTemplate class documentation (Closed)

Created:
4 years, 5 months ago by danbev
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
git@github.com:danbev/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Updating the code example in FunctionTemplate class documentation Currently the code example in the FunctionTemplate class documentation is out of date. This commit updates the examples so they compile and run without error. BUG= Committed: https://crrev.com/f810ccc86759f204f8f149ba4b40f6166d5bae2b Cr-Commit-Position: refs/heads/master@{#37741}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Breaking parameter list so that lines don't exceed 80 characters #

Patch Set 3 : Adding myself to the AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/v8.h View 1 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
danbev
4 years, 5 months ago (2016-07-05 14:14:53 UTC) #2
danno
Thanks for the patch! https://codereview.chromium.org/2127523003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2127523003/diff/1/include/v8.h#newcode4424 include/v8.h:4424: * proto_t->Set(isolate, "proto_method", v8::FunctionTemplate::New(isolate, InvokeCallback)); ...
4 years, 5 months ago (2016-07-06 09:17:46 UTC) #3
danbev
Thanks for the review! I've updated with commit fixing the lines exceeding 80 characters.
4 years, 5 months ago (2016-07-06 10:29:40 UTC) #6
jochen (gone - plz use gerrit)
can you please also add yourself to the AUTHORS file?
4 years, 5 months ago (2016-07-06 11:30:10 UTC) #7
danbev
Adding myself to the AUTHORS file.
4 years, 5 months ago (2016-07-06 11:38:31 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-06 11:41:03 UTC) #9
danno
Would you like to land this patch? If so please just check the CQ checkbox.
4 years, 5 months ago (2016-07-14 06:01:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127523003/40001
4 years, 5 months ago (2016-07-14 06:06:41 UTC) #12
danbev
On 2016/07/14 06:01:41, danno wrote: > Would you like to land this patch? If so ...
4 years, 5 months ago (2016-07-14 06:07:24 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-14 06:32:20 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 06:34:39 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f810ccc86759f204f8f149ba4b40f6166d5bae2b
Cr-Commit-Position: refs/heads/master@{#37741}

Powered by Google App Engine
This is Rietveld 408576698