Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 2127523002: [turbofan] Remove obsolete frame-state from count op. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete frame-state from count op. This removes the usage of {FrameStateBeforeAndAfter} from the graph building for count operations. The {JSAdd} or {JSSubtract} node in question no longer needs the frame-state attached. R=bmeurer@chromium.org Committed: https://crrev.com/e0dd3119e0a8e4f858d009490c502ff1e300c525 Cr-Commit-Position: refs/heads/master@{#37529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-05 11:30:07 UTC) #1
Benedikt Meurer
Nice, LGTM!
4 years, 5 months ago (2016-07-05 11:54:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127523002/1
4 years, 5 months ago (2016-07-05 12:39:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 12:41:32 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 12:41:33 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 12:42:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0dd3119e0a8e4f858d009490c502ff1e300c525
Cr-Commit-Position: refs/heads/master@{#37529}

Powered by Google App Engine
This is Rietveld 408576698