Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "core/editing/RelocatablePosition.h" | |
| 6 | |
| 7 namespace blink { | |
| 8 | |
| 9 RelocatablePosition::RelocatablePosition() | |
| 10 : m_range(nullptr) | |
|
yosin_UTC9
2016/07/06 06:50:30
You don't need to initialize |Member<Range>|
| |
| 11 { | |
| 12 } | |
| 13 | |
| 14 RelocatablePosition::RelocatablePosition(const Position& position) | |
| 15 : m_range(position.isNotNull() ? Range::create(*position.document(), positio n, position) : nullptr) | |
| 16 { | |
| 17 } | |
| 18 | |
| 19 RelocatablePosition::~RelocatablePosition() | |
| 20 { | |
| 21 if (m_range) | |
|
yosin_UTC9
2016/07/06 06:50:30
We prefer early-return style.
| |
| 22 m_range->dispose(); | |
| 23 } | |
| 24 | |
| 25 Position RelocatablePosition::position() const | |
| 26 { | |
| 27 if (!m_range) | |
| 28 return Position(); | |
| 29 DCHECK(m_range->collapsed()); | |
| 30 return m_range->startPosition(); | |
| 31 } | |
| 32 | |
| 33 } // namespace blink | |
| OLD | NEW |