Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2127483003: Revert of [heap] Track length for array buffers to avoid free-ing dependency (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Track length for array buffers to avoid free-ing dependency (patchset #2 id:20001 of https://codereview.chromium.org/2122603004/ ) Reason for revert: [Sheriff] This makes mjsunit/regress/regress-625752 extremely slow on all gc stress bots and leads to timeouts with custom snapshot: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/6602 Original issue's description: > [heap] Track length for array buffers to avoid free-ing dependency > > The dependency would only happen if we have a smi overflow for the length and > have create a heap number. In this case the heap number would've to survive > until the array buffer is collected. > > To avoid this dependency we track the length (as we previously used to). > > BUG=chromium:625748, chromium:625752 > LOG=N > TEST=test/mjsunit/regress/regress-625752.js > R=hpayer@chromium.org > > Committed: https://crrev.com/ddc75cc1356a58b6cfd63f9da0586e1150496b3d > Cr-Commit-Position: refs/heads/master@{#37530} TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:625748, chromium:625752 Committed: https://crrev.com/1791d7bb9ad26d8096bc5e2ed2216ea8b8dcc3cd Cr-Commit-Position: refs/heads/master@{#37533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -30 lines) Patch
M src/heap/array-buffer-tracker.h View 4 chunks +4 lines, -5 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/heap/array-buffer-tracker-inl.h View 2 chunks +6 lines, -8 lines 0 comments Download
D test/mjsunit/regress/regress-625752.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [heap] Track length for array buffers to avoid free-ing dependency
4 years, 5 months ago (2016-07-05 14:40:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127483003/1
4 years, 5 months ago (2016-07-05 14:40:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 14:41:06 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 14:43:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1791d7bb9ad26d8096bc5e2ed2216ea8b8dcc3cd
Cr-Commit-Position: refs/heads/master@{#37533}

Powered by Google App Engine
This is Rietveld 408576698