[PCv2] Avoid hash navigation by inserting navigation to different URL.

[PCv2] Avoid hash navigation by inserting navigation to different URL.

This CL avoids PCv2 perform hash navigation which is not handled well by
page.Navigate in inspector_page.py.

Suppose we have a page set: ["a.com", "g.com/#hoge"]
Given this page set, PCv1 used to cycle pages as:
- a.com       [cold run]
- g.com/#hoge [cold run]
- a.com       [warm run]
- g.com/#hoge [warm run]

However, PCv2 cycles the page set as:
- a.com       [cold run]
- a.com       [warm run]
- g.com/#hoge [cold run]
- g.com/#hoge [warm run]

While this gives PCv2 more opportunity for more precise cache control,
this invokes problematic hash navigation of "g.com/#hoge -> g.com/#hoge"
which doesn't flush Blink frame.

This CL workarounds the issue by inserting an navigation to
"http://does.not.exist" before the second "g.com/#hoge" nav.

BUG=chromium:624265
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9f8a0a8c0d4522f4014fbdba199222d44d638730

[kouhei (in TOK), 2016-07-05 06:51:18]

kouhei@chromium.org changed reviewers:
+ ksakamoto@google.com, nednguyen@google.com

[kouhei (in TOK), 2016-07-05 06:51:19]

This is blocking https://codereview.chromium.org/2097303002/

[Kunihiko Sakamoto, 2016-07-05 07:09:52]

ksakamoto@chromium.org changed reviewers:
+ ksakamoto@chromium.org

[Kunihiko Sakamoto, 2016-07-05 07:09:53]

lgtm

[nednguyen, 2016-07-05 12:31:03]

lgtm

[nednguyen, 2016-07-05 12:34:44]

https://codereview.chromium.org/2127483002/diff/1/telemetry/telemetry/page/ca...
File telemetry/telemetry/page/cache_temperature.py (right):

https://codereview.chromium.org/2127483002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:75: with
MarkTelemetryInternal(browser, 'avoid_hash_navigation'):
Should 'avoid_hash_navigation' be changed to 'avoid_duplicate_hash_navigation'?
Also can you add documentation about duplicate doesn't flush Blink frame & why
that is not ideal for a warm measurement.

[kouhei (in TOK), 2016-07-06 01:03:41]

Description was changed from

==========
[PCv2] Avoid hash navigation by inserting navigation to different URL.

This CL avoids PCv2 perform hash navigation which is not handled well by
page.Navigate in inspector_page.py.

Suppose we have a page set: ["a.com", "g.com/#hoge"]
Given this page set, PCv1 used to cycle pages as:
- a.com       [cold run]
- g.com/#hoge [cold run]
- a.com       [warm run]
- g.com/#hoge [warm run]

However, PCv2 cycles the page set as:
- a.com       [cold run]
- a.com       [warm run]
- g.com/#hoge [cold run]
- g.com/#hoge [warm run]

While this gives PCv2 more opportunity for more precise cache control,
this invokes problematic hash navigation of "g.com/#hoge -> g.com/#hoge"
which doesn't flush Blink frame.

This CL workarounds the issue by inserting an navigation to
"http://does.not.exist" before the second "g.com/#hoge" nav.

BUG=chromium:#624265
==========

to

==========
[PCv2] Avoid hash navigation by inserting navigation to different URL.

This CL avoids PCv2 perform hash navigation which is not handled well by
page.Navigate in inspector_page.py.

Suppose we have a page set: ["a.com", "g.com/#hoge"]
Given this page set, PCv1 used to cycle pages as:
- a.com       [cold run]
- g.com/#hoge [cold run]
- a.com       [warm run]
- g.com/#hoge [warm run]

However, PCv2 cycles the page set as:
- a.com       [cold run]
- a.com       [warm run]
- g.com/#hoge [cold run]
- g.com/#hoge [warm run]

While this gives PCv2 more opportunity for more precise cache control,
this invokes problematic hash navigation of "g.com/#hoge -> g.com/#hoge"
which doesn't flush Blink frame.

This CL workarounds the issue by inserting an navigation to
"http://does.not.exist" before the second "g.com/#hoge" nav.

BUG=chromium:624265
==========

[kouhei (in TOK), 2016-07-06 01:03:46]

https://codereview.chromium.org/2127483002/diff/1/telemetry/telemetry/page/ca...
File telemetry/telemetry/page/cache_temperature.py (right):

https://codereview.chromium.org/2127483002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:75: with
MarkTelemetryInternal(browser, 'avoid_hash_navigation'):
On 2016/07/05 12:34:44, nednguyen (ooo til 7-11) wrote:
> Should 'avoid_hash_navigation' be changed to
'avoid_duplicate_hash_navigation'?
> Also can you add documentation about duplicate doesn't flush Blink frame & why
> that is not ideal for a warm measurement.

Done.

[kouhei (in TOK), 2016-07-06 01:04:08]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2016-07-06 01:04:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, ksakamoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2127483002/#ps20001
(title: "add_note")

[commit-bot: I haz the power, 2016-07-06 01:04:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 01:26:52]

Description was changed from

==========
[PCv2] Avoid hash navigation by inserting navigation to different URL.

This CL avoids PCv2 perform hash navigation which is not handled well by
page.Navigate in inspector_page.py.

Suppose we have a page set: ["a.com", "g.com/#hoge"]
Given this page set, PCv1 used to cycle pages as:
- a.com       [cold run]
- g.com/#hoge [cold run]
- a.com       [warm run]
- g.com/#hoge [warm run]

However, PCv2 cycles the page set as:
- a.com       [cold run]
- a.com       [warm run]
- g.com/#hoge [cold run]
- g.com/#hoge [warm run]

While this gives PCv2 more opportunity for more precise cache control,
this invokes problematic hash navigation of "g.com/#hoge -> g.com/#hoge"
which doesn't flush Blink frame.

This CL workarounds the issue by inserting an navigation to
"http://does.not.exist" before the second "g.com/#hoge" nav.

BUG=chromium:624265
==========

to

==========
[PCv2] Avoid hash navigation by inserting navigation to different URL.

This CL avoids PCv2 perform hash navigation which is not handled well by
page.Navigate in inspector_page.py.

Suppose we have a page set: ["a.com", "g.com/#hoge"]
Given this page set, PCv1 used to cycle pages as:
- a.com       [cold run]
- g.com/#hoge [cold run]
- a.com       [warm run]
- g.com/#hoge [warm run]

However, PCv2 cycles the page set as:
- a.com       [cold run]
- a.com       [warm run]
- g.com/#hoge [cold run]
- g.com/#hoge [warm run]

While this gives PCv2 more opportunity for more precise cache control,
this invokes problematic hash navigation of "g.com/#hoge -> g.com/#hoge"
which doesn't flush Blink frame.

This CL workarounds the issue by inserting an navigation to
"http://does.not.exist" before the second "g.com/#hoge" nav.

BUG=chromium:624265

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-06 01:26:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...