Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2127433002: Revert of Roll src/third_party/skia/ df4f47b8f..d87a6b235 (39 commits). (patchset #1 id:1 of https:… (Closed)

Created:
4 years, 5 months ago by Kunihiko Sakamoto
Modified:
4 years, 5 months ago
Reviewers:
rmistry
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia/ df4f47b8f..d87a6b235 (39 commits). (patchset #1 id:1 of https://codereview.chromium.org/2121043003/ ) Reason for revert: Broke Mac and Linux builds. crbug.com/625728 Original issue's description: > Roll src/third_party/skia/ df4f47b8f..d87a6b235 (39 commits). > > https://chromium.googlesource.com/skia.git/+log/df4f47b8ff63..d87a6b235672 > > $ git log df4f47b8f..d87a6b235 --date=short --no-merges --format='%ad %ae %s' > 2016-07-04 benjaminwagner Revert of Increase batching for AA fill rects. (patchset #4 id:60001 of https://codereview.chromium.org/2116823002/ ) > 2016-07-02 benjaminwagner Exclude SkSL in public.bzl. > 2016-07-01 ethannicholas fixed SkSL memory leak GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119903002 NOTREECHECKS=true > 2016-07-01 ethannicholas fixed non-GPU build GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120543003 NOTREECHECKS=true > 2016-07-01 skia.buildbots Update Win toolchain > 2016-07-01 benjaminwagner Specify new Windows Toolchain isolated hash. > 2016-07-01 bsalomon Increase batching for AA fill rects. > 2016-07-01 robertphillips Split apart the GP construction for the NonAAFillRect Batches > 2016-07-01 halcanary using_skia_and_harfbuzz: use default typeface > 2016-07-01 ethannicholas initial checkin of SkSL compiler > 2016-07-01 egdaniel Use bounds of batches for render pass bounds > 2016-07-01 egdaniel Fix vulkan ImageView swizzling to match spec > 2016-07-01 bsalomon Cleanup non-AA fill rect batch construction. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119853002 > 2016-07-01 bsalomon Simplify AA fill rect batch construction and rename Geometry->RectInfo GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2116723003 > 2016-07-01 bsalomon Remove unneeded helpers in AA and non-AA rect GrBatch subclasses. > 2016-06-30 bsalomon Cleanup PLSPathBatch GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2116543002 > 2016-06-30 bsalomon Disable GPU dithering in Android framework builds GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2115683002 > 2016-06-30 bsalomon Remove unused batch rect append functions GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2106283003 > 2016-06-30 bsalomon Remove GrTInstanceBatch > 2016-06-30 vjiaoblack Fix bug where ovals' AA exceed bounds by .5 pixel > 2016-06-30 csmartdalton Begin instanced rendering for simple shapes > 2016-06-30 bsalomon Hide GrNonAANinePatchBatch::Geometry and rename to Patch GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111943002 > 2016-06-30 bsalomon Hide MSAAPathBatch::Geometry and rename to PathInfo GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2116533002 > 2016-06-30 halcanary SkPDF: Glyph Useage Map improvements > 2016-06-30 egdaniel Remove support for GL discards > 2016-06-30 msarett Fix png encoding in skia debugger > 2016-06-30 hstern Add cubic example and draw original path > 2016-06-30 jcgregorio skiaserve: Use snakeCase for JSON identifiers. > 2016-06-30 jvanverth Add static buffer support > 2016-06-30 egdaniel Add discard support to Vulkan > 2016-06-30 halcanary SkPDF: allow overriding Producer metadata > 2016-06-30 reed use mapRectScaleTranslate for common case in clipRect > 2016-06-30 bsalomon Hide GrDrawVerticesBatch::Geometry and rename to Mesh GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104383003 > 2016-06-30 jcgregorio debugger: Allow for larger images. > 2016-06-30 reed inline very common intersect+rect_rgn > 2016-06-30 hcm Update skia milestone to next > 2016-06-30 bsalomon Even more hiding of Geometry structs in GrBatch subclasses. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110853004 > 2016-06-30 reed speed up maprect for scale+trans case > 2016-06-30 borenet Add Android SDK asset > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > TBR=rmistry@google.com > > Committed: https://crrev.com/1db191f4165df78f467c37b09ee69d666fb63a8b > Cr-Commit-Position: refs/heads/master@{#403708} BUG=625728 TBR=rmistry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/99241c5cb75649c2642c9176183e6c016a731c15 Cr-Commit-Position: refs/heads/master@{#403734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127433002/1
4 years, 5 months ago (2016-07-05 03:10:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 03:11:41 UTC) #3
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 03:11:45 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 03:14:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99241c5cb75649c2642c9176183e6c016a731c15
Cr-Commit-Position: refs/heads/master@{#403734}

Powered by Google App Engine
This is Rietveld 408576698