DevTools: Switch V8ProfilerAgent to use v8::CpuProfiler::New API.

DevTools: Switch V8ProfilerAgent to use v8::CpuProfiler::New API.

The old v8::Isolate::GetCpuProfiler API is going to be deprecated soon.

Committed: https://crrev.com/44a3c6b6bbe370735a387cafbadeb68aff4a0b6b
Cr-Commit-Position: refs/heads/master@{#407245}

[alph, 2016-07-08 19:05:44]

alph@chromium.org changed reviewers:
+ pfeldman@chromium.org

[alph, 2016-07-08 19:05:45]

Pavel, could you please take a look.

[pfeldman, 2016-07-08 19:10:09]

https://codereview.chromium.org/2127423003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
(right):

https://codereview.chromium.org/2127423003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp:139: #if
V8_MAJOR_VERSION * 100 + V8_MINOR_VERSION >= 504
I'd rather that we hold off deprecation before v8 inspector is merged into v8.

[alph, 2016-07-08 19:22:10]

https://codereview.chromium.org/2127423003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
(right):

https://codereview.chromium.org/2127423003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp:139: #if
V8_MAJOR_VERSION * 100 + V8_MINOR_VERSION >= 504
On 2016/07/08 19:10:08, pfeldman wrote:
> I'd rather that we hold off deprecation before v8 inspector is merged into v8.

It landed today. What's wrong with deprecation?
The plan was to held the old API in v8 for couple releases.

[pfeldman, 2016-07-08 19:24:59]

> It landed today. What's wrong with deprecation?
> The plan was to held the old API in v8 for couple releases.

Nothing wrong with it, but it is in the way of the v8_inspector migration and v8
team offered their help in making it smooth.

[pfeldman, 2016-07-22 18:04:25]

lgtm

[alph, 2016-07-22 18:47:57]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-07-22 18:48:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 20:22:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-22 20:25:48]

Description was changed from

==========
DevTools: Switch V8ProfilerAgent to use v8::CpuProfiler::New API.

The old v8::Isolate::GetCpuProfiler API is going to be deprecated soon.
==========

to

==========
DevTools: Switch V8ProfilerAgent to use v8::CpuProfiler::New API.

The old v8::Isolate::GetCpuProfiler API is going to be deprecated soon.

Committed: https://crrev.com/44a3c6b6bbe370735a387cafbadeb68aff4a0b6b
Cr-Commit-Position: refs/heads/master@{#407245}
==========

[commit-bot: I haz the power, 2016-07-22 20:25:49]

Patchset 5 (id:??) landed as
https://crrev.com/44a3c6b6bbe370735a387cafbadeb68aff4a0b6b
Cr-Commit-Position: refs/heads/master@{#407245}