Source/bindings/v8/V8Binding.h - Issue 21274004: Fix Document leak from NodeFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Binding.h

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: don't print numberOfLiveDocuments when test passed Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8Binding.h

diff --git a/Source/bindings/v8/V8Binding.h b/Source/bindings/v8/V8Binding.h

index 8571a529d11e2531519e9852cf75db66a3141902..e1712bcdc073136432186ee1682742ace1520772 100644

--- a/Source/bindings/v8/V8Binding.h

+++ b/Source/bindings/v8/V8Binding.h

@@ -512,7 +512,7 @@ namespace WebCore {

return v8Value;

}

- PassRefPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value>);

+ PassRefPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value>, v8::Isolate*);

inline bool isUndefinedOrNull(v8::Handle<v8::Value> value)

{