Source/bindings/scripts/deprecated_code_generator_v8.pm - Issue 21274004: Fix Document leak from NodeFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add assertions to wrap Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/deprecated_code_generator_v8.pm

diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm

index d49ce7ef64eb85e1da4c90c794b23ada80e61206..8c8d25e99d8888a52754038635fbfaf94d8ec39d 100644

--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm

+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm

@@ -5146,7 +5146,7 @@ sub JSValueToNative

}

if ($type eq "NodeFilter") {

- return "toNodeFilter($value)";

+ return "toNodeFilter($value, $getIsolate)";

}

if ($type eq "MediaQueryListListener") {