Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: Source/bindings/v8/custom/V8TreeWalkerCustom.cpp

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: don't print numberOfLiveDocuments when test passed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/custom/V8NodeIteratorCustom.cpp ('k') | Source/core/dom/NodeFilter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 11 matching lines...) Expand all
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "core/dom/NodeList.h" 32 #include "V8TreeWalker.h"
33 33
34 #include "V8NodeFilter.h"
35 #include "bindings/v8/V8Binding.h"
36 #include "bindings/v8/V8HiddenPropertyName.h"
34 #include "core/dom/Node.h" 37 #include "core/dom/Node.h"
35 38
36 namespace WebCore { 39 namespace WebCore {
37 40
38 void NodeList::anonymousNamedGetter(const AtomicString& name, bool& returnValue0 Enabled, RefPtr<Node>& returnValue0, bool& returnValue1Enabled, unsigned& return Value1) 41 v8::Handle<v8::Object> wrap(TreeWalker* treeWalker, v8::Handle<v8::Object> creat ionContext, v8::Isolate* isolate)
39 { 42 {
40 // Length property cannot be overridden. 43 ASSERT(treeWalker);
41 DEFINE_STATIC_LOCAL(const AtomicString, length, ("length", AtomicString::Con structFromLiteral)); 44 ASSERT(DOMDataStore::getWrapper<V8TreeWalker>(treeWalker, isolate).IsEmpty() );
42 if (name == length) {
43 returnValue1Enabled = true;
44 returnValue1 = this->length();
45 return;
46 }
47 45
48 Node* result = namedItem(name); 46 v8::Handle<v8::Object> wrapper = V8TreeWalker::createWrapper(treeWalker, cre ationContext, isolate);
49 if (!result)
50 return;
51 47
52 returnValue0Enabled = true; 48 if (treeWalker->filter())
53 returnValue0 = result; 49 V8HiddenPropertyName::setNamedHiddenReference(wrapper, "filter", toV8(tr eeWalker->filter(), creationContext, isolate));
50
51 return wrapper;
54 } 52 }
55 53
56
57 } // namespace WebCore 54 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8NodeIteratorCustom.cpp ('k') | Source/core/dom/NodeFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698